Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update eval tests #5547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Update eval tests #5547

merged 1 commit into from
Jun 2, 2025

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented May 28, 2025

In the vein of #5455. This also uses the 'int' min_prelude being added by #5546.

@jonmeow
Copy link
Contributor Author

jonmeow commented May 28, 2025

Note this is stacked on #5546, please focus on the "Update eval tests" commit

@github-actions github-actions bot requested a review from chandlerc May 28, 2025 18:23
@jonmeow jonmeow mentioned this pull request May 30, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 2, 2025
The general intent here is to support basic use of `i32` and similar
integer types in min_prelude tests, without all the various arithmetic
support.

This is in support of #5547 and #5549. However, I was originally asking
for this to be reviewed as part of #5546 rather than either of those
PRs, and I've retracted #5546 due to [the discussion on Discord about
test change
complexity](https://discord.com/channels/655572317891461132/655578254970716160/1377406366200758293).
So, to try to still get this in (and then merge the already-approved
#5547 and #5549), splitting out this file.

Note this is actually the form of the prelude in #5549, which was adding
negate -- it felt better to me to add that together as long as I'm
splitting it out.
@jonmeow jonmeow enabled auto-merge June 2, 2025 16:00
@jonmeow jonmeow added this pull request to the merge queue Jun 2, 2025
Merged via the queue into carbon-language:trunk with commit 39a7010 Jun 2, 2025
8 checks passed
@jonmeow jonmeow deleted the eval-tests branch June 2, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.