-
Notifications
You must be signed in to change notification settings - Fork 3.4k
5.next Add compact command list output by default #19092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.next
Are you sure you want to change the base?
Conversation
Groups subcommands together (e.g., `cache [clear|clear_all|...]`) and hides descriptions. Use `--verbose` to see expanded output with descriptions and paths. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Current Paths is now only shown in verbose mode. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Shows users how to see command descriptions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file is for local reference only. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
All commands starting with 'bake' are now grouped together regardless of which plugin provides them. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
I would still prefer to show groups (with added group description if possible) as default.
Your truncating is maybe a bit too extreme. As @ADmad already mentioned. It is the responsibility of the maintainer to make it fit. Let's take composer as an example here. There's no real limit in descriptions and it is just wrapping to a newline if the window is too small. I have no issues with that. A hard limit of 150 chars or something would be better than the 60? char limit you now set?
Come to think of it, i think (not validated) that composer calculates the max length of the longest command name and uses that length as the whitespace between command and description. This would also give a more natural feel Adding my idea from original PR as reference for further discussion: |
|
The grouping is imo flawed and counterproductive with plugins adding to the same Main command. The view as it is now is already too long. But I think its a fair compromise. Just add 2 character for your normal view: |
|
Some type of grouping / breathing points is a must. A continuous wall of text is very difficult to read. |
|
The group key makes way more sense! 👍 In the end its not what plugin brings what, but whats the actual command naming. |
Can we include the actual full command again ? Next chore would be to add descriptions for all core commands that now have missing descriptions. My OCD cannot handle this mess right now @dereuromark did you read my remark in my first post about truncating? What's your take on that |
|
It is also the maintainers responsibility of keeping the desc short, and instead add more info into helptext. As for full command and repeating group name: |
agreed but its a bit too strict now right?, most simple descriptions are now truncated. You could at least double the available chars.
👍 |
|
I tried this, but it looks awful, as now there is spacing on the front larger than the grouping if its more than one line.. But again, I think we should trim down the descr text here more by default to concise info, and instead make the help text more multiline explanations. That would fit all cases then, right? |
|
could we group those single comands under a global fallback key or something? Bit uncosmetic how they now float |
|
Then they are not ordered, though. The whole idea is that you can now really find them in alphabetical order. no matter what plugin might add them (which is usually not relevant with the new command naming pattern and renaming possibilities). I think this will solve itself, once people use the structuring with min 2 elements: (cake3 naming) should be so always at least 2 elements (grouping and concrete topic) Which is basically what laravel and symfony have been doing for years with this |
I don't really mind if they are not ordered. If there's no grouping key they should be nested under an "available commands" key. They are probably ordered in that list then :-) I agree with that it will solve itself. A reason more to add them under a fallback key. I believe this is also the case when you create ungrouped drush (drupal) commands and symfony commands... |
|
I like that, just also indent the global commands so they are on the same level as the other "child" ones :-) |
|
I added "CakePHP version + debug info" to verbose output Full output of default for my sandbox for example: Looks quite clean. |
|
I extracted the fixes and improvements for now into #19108 |







Alternative to #19085
Composer-style inline
Key changes:
Also fixed:
bin/cake bake -hfor bake specific options etcReal app example (with plugins)
probably a good compromise between concise and readable.