Improve logs to detect double activity events #6839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // this can be removed after the root cause is identified and fixed | ||
| // TODO: remove this after the root cause is identified and fixed or add deduplication | ||
| e.logDuplicatedActivityEvents(e.bufferedEvents) | ||
| e.logDuplicatedActivityEvents(e.updateBufferedEvents) |
There was a problem hiding this comment.
are you going to be able to disambiguate these two events if they're logged?
davidporter-id-au
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Split down the logs and added them in better locations to be able to identify whether the duplication comes from when the events are added, when they are being buffered or after that.
Why?
Previously it would not be possible to know where the duplication came from.
How did you test it?
Unit test and local tests
Potential risks
There may be some latency added when flushing buffered events, but it shouldn't be significative.
Release notes
Documentation Changes