Change the default value of Task Isolation configs #6833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default value of matching.taskIsolationPollerWindow from 10s to 2s. Most tasks are dispatched in a matter of milliseconds. 10s is a proportionately huge number. We should begin abandoning isolation faster any time we lose pollers from an isolation group. Individual tasks still have a TaskIsolationDuration which will result in an eventual leak, but when we lose all pollers from an isolation group we want to stop imposing that penalty on every task as quickly as possible. Similarly change the value of TaskIsolationDuration from 0 (indefinite isolation) to 200ms. Initially we had considered values of 1-5s, but these are similarly a proportionately huge number compared to normal dispatch rates.
taylanisikdemir
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default value of matching.taskIsolationPollerWindow from 10s to 2s. Most tasks are dispatched in a matter of milliseconds. 10s is a proportionately huge number. We should begin abandoning isolation faster any time we lose pollers from an isolation group.
Individual tasks still have a TaskIsolationDuration which will result in an eventual leak, but when we lose all pollers from an isolation group we want to stop imposing that penalty on every task as quickly as possible.
Similarly change the value of TaskIsolationDuration from 0 (indefinite isolation) to 200ms. Initially we had considered values of 1-5s, but these are similarly a proportionately huge number compared to normal dispatch rates.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes