[common][dynamicconfig] Revamp dynamicconfig package to provide a cleanier boundaries of functionality #6788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anier boundaries of functionality
dkrotx
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactored dynamic config components to ensure no circular dependencies during future refactoring.
There are no logical changes - only the move of components.
Why?
I am cleaning up dependencies to ensure future FX integration is possible. Various components are interdependent, and this refactoring eliminates circular dependencies. It may require customers with custom implementations using dynamic config to adjust import paths; otherwise, it should be safe.
How did you test it?
Unit tests
Potential risks
Complications during release update.
Release notes
Refactoring dynamic config components may require adjusting imports.
Documentation Changes