Adjust task isolation metrics #6784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the isolation group that we're currently dispatching the task as. It isn't useful. We only care whether the original matches the poller. Add an explicit metric to count when the original group matches the poller. This is a lot easier to monitor and query compared to finding where the tags match.
davidporter-id-au
approved these changes
Apr 4, 2025
davidporter-id-au
approved these changes
Apr 4, 2025
taylanisikdemir
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're dispatching a task we have three groups:
"".Remove the isolation group that we're currently dispatching the task as. It isn't useful. We only care whether the original matches the poller. I originally added it in #6544 to try and evaluate whether we're "incidentally" getting successes, but it really doesn't matter. We have subsequently added another metric to report when we abandon isolation and why.
Add an explicit metric to count when the original group matches the poller. This is a lot easier to monitor and query compared to finding where the tags match.
What changed?
isolation_task_matches_per_tlisolation_success_per_tlany time the group the task is from matches the poller.Why?
How did you test it?
Potential risks
Release notes
Documentation Changes