Unify complete history tasks methods #6763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
approved these changes
Mar 28, 2025
| if c.enableShardIDMetrics() { | ||
| err = c.callWithDomainAndShardScope(metrics.PersistenceCompleteReplicationTaskScope, op, metrics.DomainTag(domainName), | ||
| err = c.callWithDomainAndShardScope(metrics.PersistenceCompleteHistoryTaskScope, op, metrics.DomainTag(domainName), |
There was a problem hiding this comment.
since we converged into single metric name, let's include task category as a metric tag so that we still have visibility into breakdown per category
There was a problem hiding this comment.
Make sense. Let me do it in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Unify complete history tasks methods
Why?
To support arbitrary history tasks
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes