Unset resource limits and requests #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btungut
added a commit
that referenced
this pull request
Jun 10, 2025
* Update VSTS agent version to 4.255.0 in Dockerfile * Bump chart version to 2.3.0 * feat: Add `git-lfs` to base image (#37) by hangy * docs: Update README with release notes for version 2.3.0 and add `git-lfs` support * refactor: Update resource limits section in values.yaml to be commented out (#39) * docs: Update README with breaking change regarding container resource requests and limits * fix: Update appVersion and image tag to v2.3.0-vsts-v2.255.0 --------- Co-authored-by: hangy <hangy@hangy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the
chart/values.yamlfile to make resource limits and requests configurable by commenting out the default settings and providing instructions for customization.Configuration changes:
chart/values.yaml: Replaced hardcodedresourceslimits and requests with a commented-out configuration block, allowing users to uncomment and customize these settings based on their Kubernetes cluster's needs. Added a note emphasizing the importance of setting resource limits appropriately.