start-time-improvement #3311
Merged
start-time-improvement #3311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…awaited in downstream actions
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Agent Task Evaluation Results: 1/2 (50%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="browser_use/browser/session.py">
<violation number="1" location="browser_use/browser/session.py:460">
`start()` now returns before the browser is connected, so callers awaiting it will see an uninitialized session. This breaks existing expectations and leaves `_cdp_client_root` unset when tests and runtime code resume.</violation>
<violation number="2" location="browser_use/browser/session.py:521">
Avoid hardcoded 10-second sleep here; it introduces unnecessary startup delay. If a wait is required, use a readiness check or make the delay configurable instead of blocking.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for branch: start-time-improvement
Note
Eliminates the 200ms sleep after
CreateAgentSessionEventsoCreateAgentTaskEventis dispatched immediately, improving startup time.Written by Cursor Bugbot for commit fb9e192. This will update automatically on new commits. Configure here.