Add Test for URL Allowlist Bypass Prevention #1687
Open
+78
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new test to ensure that the URL allowlist functionality is properly enforced, specifically preventing navigation to disallowed URLs. The test verifies that attempts to redirect to https://www.google.com are blocked when the domain is not in the allowed list.
@pirate @LarsenCundric
currently anyone can bypass the allowed_domains using redirection. (i think there are other methods as well).
Summary by mrge
Added a new test to make sure the URL allowlist blocks navigation to disallowed domains, even when a page tries to redirect.