Added region as a parameter for aws-mfa. #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please allow this to merge into the repo. I too had this issue for govcloud |
|
This is also needed to work with S3 Multi Region Access Points, which don't work with temporary credentials from the global STS endpoint. https://docs.aws.amazon.com/AmazonS3/latest/userguide/MultiRegionAccessPointRestrictions.html |
|
The commit here is not enough, you must also set the endpoint_url when creating the client. See #52 which has it working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the issue(#76), I changed the code. Since I tested when calling sts API without region vs with region. Boto3 resolved to the correct API endpoint when the region was passed. So I made the change to the code to make the package accept region as an additional parameter.
Assumption: .aws/credentials file should contain the region as a required parameter.