Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

improvement: remove edge deletion confirmation dialog#336

Merged
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
improvement/remove-edge-delete-confirmationbreaking-brake/cc-wf-studio:improvement/remove-edge-delete-confirmationCopy head branch name to clipboard
Dec 30, 2025
Merged

improvement: remove edge deletion confirmation dialog#336
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
improvement/remove-edge-delete-confirmationbreaking-brake/cc-wf-studio:improvement/remove-edge-delete-confirmationCopy head branch name to clipboard

Conversation

@breaking-brake
Copy link
Copy Markdown
Owner

Summary

  • Remove confirmation dialog when deleting edge connections
  • Edge now deletes immediately when × button is clicked

Rationale

  • Reconnecting edges is easy if deleted by mistake (low cost of error recovery)
  • Confirmation dialog for every edge deletion is tedious for users

Changes

  • DeletableEdge.tsx: Use useReactFlow().setEdges for direct deletion
  • workflow-store.ts: Remove pendingDeleteEdgeIds, requestDeleteEdge, confirmDeleteEdges, cancelDeleteEdges
  • App.tsx: Remove edge deletion confirmation dialog
  • SubAgentFlowDialog.tsx: Remove edge deletion confirmation dialog and unused ConfirmDialog import
  • i18n files: Remove dialog.deleteEdge.* keys from all 5 languages (en, ja, ko, zh-CN, zh-TW)

Testing

  • Manual E2E testing completed
  • Code quality checks passed (npm run format && npm run lint && npm run check)
  • Build succeeded (npm run build)

🤖 Generated with Claude Code

- Edge now deletes immediately when × button is clicked
- Removed pendingDeleteEdgeIds and related actions from workflow-store
- Removed ConfirmDialog for edge deletion from App.tsx and SubAgentFlowDialog.tsx
- Removed dialog.deleteEdge.* i18n keys from all 5 languages

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@breaking-brake breaking-brake merged commit b375974 into main Dec 30, 2025
3 checks passed
@breaking-brake breaking-brake deleted the improvement/remove-edge-delete-confirmation branch December 30, 2025 13:29
@breaking-brake breaking-brake mentioned this pull request Dec 30, 2025
braking-brake-semantic-release Bot pushed a commit that referenced this pull request Dec 30, 2025
## [3.10.2](v3.10.1...v3.10.2) (2025-12-30)

### Improvements

* remove edge deletion confirmation dialog ([#336](#336)) ([b375974](b375974))
@braking-brake-semantic-release
Copy link
Copy Markdown

🎉 This PR is included in version 3.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.