Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

improvement: prevent dropdown menu from closing on settings selection#304

Merged
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
improvement/prevent-dropdown-close-on-settingsbreaking-brake/cc-wf-studio:improvement/prevent-dropdown-close-on-settingsCopy head branch name to clipboard
Dec 22, 2025
Merged

improvement: prevent dropdown menu from closing on settings selection#304
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
improvement/prevent-dropdown-close-on-settingsbreaking-brake/cc-wf-studio:improvement/prevent-dropdown-close-on-settingsCopy head branch name to clipboard

Conversation

@breaking-brake
Copy link
Copy Markdown
Owner

Problem

In the AI editing settings dropdown menu, clicking on Model, Timeout, or Allowed Tools submenu items closes the dropdown menu immediately after selection.

Current Behavior

  1. Open Settings dropdown
  2. Navigate to Model/Timeout/Allowed Tools submenu
  3. ❌ Click an option → Dropdown closes

Expected Behavior

  1. Open Settings dropdown
  2. Navigate to Model/Timeout/Allowed Tools submenu
  3. ✅ Click an option → Dropdown stays open for further adjustments

Solution

Add event.preventDefault() to prevent default menu closing behavior on selection.

Changes

File: src/webview/src/components/chat/SettingsDropdown.tsx

  • Add event.preventDefault() to Model submenu RadioItems
  • Add event.preventDefault() to Timeout submenu RadioItems
  • Add event.preventDefault() to Reset to Default button

Impact

  • Improved UX: Users can make multiple setting changes without reopening the dropdown
  • Consistent behavior with Allowed Tools checkboxes (which already had this fix)

Testing

  • Manual E2E testing completed
  • Code quality checks passed (npm run format && npm run lint && npm run check)
  • Build successful (npm run build)

🤖 Generated with Claude Code

- Add event.preventDefault() to Model submenu RadioItems
- Add event.preventDefault() to Timeout submenu RadioItems
- Add event.preventDefault() to Reset to Default button
@breaking-brake breaking-brake merged commit 544cc42 into main Dec 22, 2025
3 checks passed
@breaking-brake breaking-brake deleted the improvement/prevent-dropdown-close-on-settings branch December 22, 2025 00:21
@breaking-brake breaking-brake mentioned this pull request Dec 22, 2025
github-actions Bot added a commit that referenced this pull request Dec 22, 2025
## [3.8.5](v3.8.4...v3.8.5) (2025-12-22)

### Bug Fixes

* remove BM25 codebase indexing feature ([#303](#303)) ([7a5878d](7a5878d))
* remove unused timeout setting and enable proper AI cancellation ([#305](#305)) ([666a231](666a231))

### Improvements

* prevent dropdown menu from closing on settings selection ([#304](#304)) ([544cc42](544cc42))
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.8.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.