Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: add close button to PropertyPanel with tour highlight fix#226

Merged
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
feature/property-panel-close-buttonbreaking-brake/cc-wf-studio:feature/property-panel-close-buttonCopy head branch name to clipboard
Dec 6, 2025
Merged

feat: add close button to PropertyPanel with tour highlight fix#226
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
feature/property-panel-close-buttonbreaking-brake/cc-wf-studio:feature/property-panel-close-buttonCopy head branch name to clipboard

Conversation

@breaking-brake
Copy link
Copy Markdown
Owner

Problem

Current Behavior

  1. PropertyPanel cannot be hidden - users have no way to expand canvas area
  2. ❌ Empty "プロパティ ×" header was showing when no node selected
  3. ❌ When AI editing panel open → select node → deselect node, AI panel closes permanently
  4. ❌ During onboarding tour, PropertyPanel step was not highlighted because panel wasn't visible

Expected Behavior

  1. ✅ Users can close PropertyPanel with × button to expand canvas area
  2. ✅ PropertyPanel only shows when a node is selected
  3. ✅ AI editing panel state is preserved when selecting/deselecting nodes
  4. ✅ During onboarding tour, PropertyPanel is properly highlighted

Solution

Add × button to PropertyPanel header and implement proper panel visibility logic with tour highlight fix.

Key Changes

  1. PropertyPanel close button: Added × button in header (same style as RefinementChatPanel)
  2. Panel visibility logic: Only show PropertyPanel when selectedNodeId && isPropertyPanelOpen
  3. Panel priority: PropertyPanel > RefinementChatPanel when node is selected
  4. Auto-reopen: Selecting a node automatically opens PropertyPanel
  5. Tour highlight fix: Use Driver.js step-level callbacks to select Start node before property panel step

Changes

src/webview/src/stores/workflow-store.ts

  • Added isPropertyPanelOpen state
  • Added openPropertyPanel() and closePropertyPanel() actions
  • Modified setSelectedNodeId() to auto-open panel when node selected

src/webview/src/components/PropertyPanel.tsx

  • Added × button in header
  • Removed no-selection message display

src/webview/src/App.tsx

  • Changed panel display condition to selectedNodeId && isPropertyPanelOpen
  • PropertyPanel now takes priority over RefinementChatPanel

src/webview/src/components/WorkflowEditor.tsx

  • Removed closeChat() call from handleNodeClick to preserve AI panel state

src/webview/src/constants/tour-steps.ts

  • Added step-level onNextClick/onPrevClick callbacks
  • Exported PROPERTY_PANEL_STEP_INDEX constant

src/webview/src/components/Tour.tsx

  • Pass callbacks to getTourSteps() for node selection timing
  • Select Start node before property panel step (via Canvas step's onNextClick)

Translation files (5 languages)

  • Removed unused property.noSelection key

Impact

  • UX improvement: Users can now hide PropertyPanel to get more canvas space
  • Panel behavior is consistent with RefinementChatPanel
  • No breaking changes - PropertyPanel auto-opens on node selection

Testing

  • PropertyPanel × button closes panel
  • Selecting a node reopens PropertyPanel
  • Canvas expands when PropertyPanel is closed
  • AI editing panel state preserved when selecting/deselecting nodes
  • Onboarding tour properly highlights PropertyPanel
  • Going back in tour re-selects Start node for PropertyPanel step
  • Code quality checks passed (format, lint, check)
  • Build successful

🤖 Generated with Claude Code

- Add × button to PropertyPanel header to allow hiding the panel
- Panel only shows when a node is selected (closes when × clicked)
- PropertyPanel takes priority over RefinementChatPanel when node selected
- Remove unused property.noSelection translation key from all languages
- Fix tour highlight by selecting Start node before property panel step
- Use Driver.js step-level onNextClick/onPrevClick for proper timing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@breaking-brake breaking-brake merged commit 0004663 into main Dec 6, 2025
3 checks passed
@breaking-brake breaking-brake deleted the feature/property-panel-close-button branch December 6, 2025 11:43
@breaking-brake breaking-brake mentioned this pull request Dec 6, 2025
github-actions Bot added a commit that referenced this pull request Dec 6, 2025
## [3.3.0](v3.2.4...v3.3.0) (2025-12-06)

### Features

* add close button to PropertyPanel with tour highlight fix ([#226](#226)) ([0004663](0004663))
* add workflow reset button to toolbar ([#225](#225)) ([2b8fb54](2b8fb54))
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 6, 2025

🎉 This PR is included in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.