Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: remove Author display and users:read scope from Slack sharing#187

Merged
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
fix/remove-slack-author-and-users-read-scopebreaking-brake/cc-wf-studio:fix/remove-slack-author-and-users-read-scopeCopy head branch name to clipboard
Dec 1, 2025
Merged

fix: remove Author display and users:read scope from Slack sharing#187
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
fix/remove-slack-author-and-users-read-scopebreaking-brake/cc-wf-studio:fix/remove-slack-author-and-users-read-scopeCopy head branch name to clipboard

Conversation

@breaking-brake
Copy link
Copy Markdown
Owner

Problem

After migrating to User Token, the Slack message poster is automatically the logged-in user, making the explicit Author display redundant.

Current Behavior

  1. Share workflow to Slack
  2. ❌ Message displays Author: @username and Date: 2025/12/1
  3. ❌ OAuth requests unnecessary users:read scope

Expected Behavior

  1. Share workflow to Slack
  2. ✅ Poster is automatically shown in Slack's native poster field (due to User Token posting)
  3. ✅ Only minimal required scopes are requested

Solution

Remove features that became unnecessary after User Token migration:

  • Remove users:read scope from OAuth
  • Remove getUserInfo() method from SlackApiService
  • Remove Author/Date display blocks from Slack messages
  • Remove Note message from import links

Changes

File: src/extension/services/slack-oauth-service.ts

  • Remove users:read from userScopes

File: src/extension/services/slack-api-service.ts

  • Remove getUserInfo() method entirely

File: src/extension/commands/slack-share-workflow.ts

  • Remove Author-related variables and code
  • Remove createdAt related code

File: src/extension/utils/slack-message-builder.ts

  • Remove authorName, authorUserId, createdAt fields from interface
  • Remove Author/Date block from message builder
  • Remove Note message from import links section

Impact

  • Slack messages become simpler and cleaner
  • OAuth requested scopes are reduced (privacy improvement)
  • No breaking changes

Testing

  • Manual E2E testing completed
  • Code quality checks passed (npm run format && npm run lint && npm run check)
  • Build successful (npm run build)

🤖 Generated with Claude Code

- Remove users:read scope from OAuth (no longer needed with User Token)
- Remove getUserInfo() method from SlackApiService
- Remove Author and Date display from Slack message blocks
- Remove Note about workspace from import links

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@breaking-brake breaking-brake merged commit 17aaa83 into main Dec 1, 2025
3 checks passed
github-actions Bot added a commit that referenced this pull request Dec 1, 2025
## [2.17.3](v2.17.2...v2.17.3) (2025-12-01)

### Bug Fixes

* remove Author display and users:read scope from Slack sharing ([#187](#187)) ([17aaa83](17aaa83))
* remove Bot Token required check from manual connection ([#189](#189)) ([18c00d7](18c00d7))
* update Slack App setup instructions for User Token only ([#188](#188)) ([a8e4463](a8e4463))
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2025

🎉 This PR is included in version 2.17.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@breaking-brake breaking-brake deleted the fix/remove-slack-author-and-users-read-scope branch December 3, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.