Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: improve Slack import error handling and add files:read scope#169

Merged
breaking-brake merged 2 commits intomainbreaking-brake/cc-wf-studio:mainfrom
fix/slack-import-workspace-not-connected-error-dialogbreaking-brake/cc-wf-studio:fix/slack-import-workspace-not-connected-error-dialogCopy head branch name to clipboard
Nov 29, 2025
Merged

fix: improve Slack import error handling and add files:read scope#169
breaking-brake merged 2 commits intomainbreaking-brake/cc-wf-studio:mainfrom
fix/slack-import-workspace-not-connected-error-dialogbreaking-brake/cc-wf-studio:fix/slack-import-workspace-not-connected-error-dialogCopy head branch name to clipboard

Conversation

@breaking-brake
Copy link
Copy Markdown
Owner

Problem

Issue 1: Workspace Not Connected Error Dialog

When importing a workflow from Slack, if the source workspace is not connected, users saw an error without clear guidance on what to do next.

Issue 2: Missing OAuth Scope

Importing workflows from workspaces other than cc-wf-studio failed with permission errors because the files:read scope was missing from OAuth authentication.

Error observed:

{
  "error": "missing_scope",
  "needed": "files:read",
  "provided": "chat:write,files:write,channels:read,groups:read"
}

Solution

Fix 1: Add SlackConnectionRequiredDialog

  • Created new dialog component to prompt users to connect to the source workspace
  • Display workspace name (Base64 encoded in deep links) for clear identification
  • Added i18n translations for 5 languages (en, ja, ko, zh-CN, zh-TW)

Fix 2: Add files:read OAuth Scope

  • Added files:read to required OAuth scopes in slack-oauth-service.ts
  • This enables downloading workflow files from any connected workspace

Changes

New Files

  • src/webview/src/components/dialogs/SlackConnectionRequiredDialog.tsx

Modified Files

  • src/extension/services/slack-oauth-service.ts - Added files:read scope
  • src/extension/commands/slack-share-workflow.ts - Pass workspaceName through flow
  • src/extension/commands/slack-import-workflow.ts - Handle WORKSPACE_NOT_CONNECTED error
  • src/extension/utils/slack-message-builder.ts - Add workspaceName to deep links
  • src/extension/utils/slack-error-handler.ts - Add workspaceId to error info
  • src/shared/types/messages.ts - Add workspaceName to payload types
  • src/webview/src/App.tsx - Handle error and show dialog
  • i18n translation files (5 languages)

Impact

  • Users can now see which workspace they need to connect when importing fails
  • Workflow import from other workspaces now works after re-authenticating with Slack
  • Note: Existing users must re-authenticate with Slack to get the new files:read scope

Testing

  • Manual E2E testing completed
  • Code quality checks passed (format, lint, check, build)

🤖 Generated with Claude Code

breaking-brake and others added 2 commits November 29, 2025 16:01
- Add workspaceName parameter to Slack message card deep links (Base64 encoded)
- Display workspace name instead of workspace ID in error dialogs
- Pass workspaceName through import flow from URI to dialog
- Add SlackConnectionRequiredDialog component for prompting Slack connection
- Add i18n translations for 5 languages (en, ja, ko, zh-CN, zh-TW)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Added files:read to required Slack OAuth scopes
- Fixes import failure from other workspaces due to missing permission

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@breaking-brake breaking-brake merged commit 740eef3 into main Nov 29, 2025
3 checks passed
@breaking-brake breaking-brake mentioned this pull request Nov 29, 2025
github-actions Bot added a commit that referenced this pull request Nov 29, 2025
## [2.15.1](v2.15.0...v2.15.1) (2025-11-29)

### Bug Fixes

* improve Slack import error handling and add files:read scope ([#169](#169)) ([740eef3](740eef3))
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@breaking-brake breaking-brake mentioned this pull request Nov 29, 2025
@breaking-brake breaking-brake deleted the fix/slack-import-workspace-not-connected-error-dialog branch December 3, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.