[EHN] Including LGGNET #647
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bruAristimunha We already have the list of channel names through the 'chs_info' parameter :) 'chs_info[i]["name"]' |
|
oh yet! Suuuuper true @PierreGtch I was just remembering that it was a dictionary, not that it was a list. All solved =) I will integrate the rest of the models too ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This architecture is a little more complicated. Together with MEET, EEGProgress, EEGSym, and TsinceptionV2, the model needs the channel names with indexes for different reasons.
I need help deciding if I should include channel_list into the base braindecode or infer or even leave this to be informed when defining the model. (This breaks the convention we established in the last sprint)....
Ideas about the design @agramfort, @tomMoral, @PierreGtch, @robintibor?