feat: added missing permissions #1501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
We should really rewrite how our permissions work at some point, having to keep making functions to check a permission is rather annoying and overly repetitive. I've got an idea on what we can do, I'll make a draft PR with it soon to see what we think. |
Jaskowicz1
commented
Oct 7, 2025
| bool role::has_use_soundboard() const { | ||
| return has_administrator() || permissions.has(p_use_soundboard); | ||
| } | ||
| bool role::has_create_guild_expressions() const { |
There was a problem hiding this comment.
Need space between functions.
include/dpp/role.h
Outdated
| * | ||
| * @note Having the administrator permission causes this method to always return true | ||
| * Channel specific overrides may apply to permissions. | ||
| * @return bool True if user has the send polls permission or is administrator. |
There was a problem hiding this comment.
Double space after the send polls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing permissions listed on discord's docs
Code change checklist