Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fixed PHP 8.1 compatibility of the requirement checker #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Fixed PHP 8.1 compatibility of the requirement checker #578

merged 2 commits into from
Dec 31, 2021

Conversation

GrahamCampbell
Copy link
Contributor

It looks like #557 wasn't enough to fix this. This file needs updating too.

@freekmurze
Copy link

This PR seems to fix PHP 8.1 compatibility. 👍

I'll just create a fork with this fix and use that until it is merged in.

@GrahamCampbell
Copy link
Contributor Author

I am using my fork. ;)

@Jeckerson
Copy link

@theofidry ping

@jakzal
Copy link

jakzal commented Dec 21, 2021

The build failure:

atal error: During inheritance of IteratorAggregate: Uncaught ErrorException: Return type of Symfony\Component\Console\Helper\HelperSet::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/box/box/vendor/symfony/console/Helper/HelperSet.php:103
#0 /home/runner/work/box/box/vendor/symfony/console/Helper/HelperSet.php(22): KevinGH\Box\{closure}()

will probably be fixed by symfony/symfony#42260

@jakzal
Copy link

jakzal commented Dec 30, 2021

The above fix was released in Symfony 4.4.30, 5.3.7, 5.4.0, and 6.0.0.

@theofidry
Copy link
Member

Thank you. Will update the Symfony dependencies shortly

@theofidry theofidry merged commit ae60392 into box-project:master Dec 31, 2021
@GrahamCampbell GrahamCampbell deleted the patch-1 branch December 31, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.