add version check to bagel#46
Open
SUSTAPLE117 wants to merge 2 commits intomainboostsecurityio/bagel:mainfrom
Open
add version check to bagel#46SUSTAPLE117 wants to merge 2 commits intomainboostsecurityio/bagel:mainfrom
SUSTAPLE117 wants to merge 2 commits intomainboostsecurityio/bagel:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an opt-out, once-per-day version update check to the Bagel CLI, including persisted local state and documented telemetry/controls.
Changes:
- Introduces
pkg/versioncheckto persist per-user state and call a version-check endpoint on a 24h interval. - Wires the version check into CLI startup and adds
--disable-version-checkplus config support viadisable_version_check. - Documents the behavior/telemetry and updates Go module dependencies.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the new flag/config/env controls and the telemetry details. |
| cmd/bagel/root.go | Runs the version check during CLI startup; adds flag + viper binding; skips for completion. |
| pkg/models/config.go | Adds disable_version_check to the config model. |
| pkg/versioncheck/config.go | Persists version-check state to the user config directory. |
| pkg/versioncheck/versioncheck.go | Implements interval gating, request construction, and response parsing. |
| pkg/versioncheck/versioncheck_test.go | Adds unit tests covering interval/disable/dev-version behavior and state persistence. |
| bagel.yaml | Adds commented example config for disabling version checks. |
| go.mod | Adds direct dependencies needed for version check (uuid, yaml). |
| go.sum | Updates checksums for new dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.