Basic JS is completed #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-hamblin
reviewed
Sep 8, 2017
Contributor
ryan-hamblin
left a comment
There was a problem hiding this comment.
Things look really good here. I don't see any major discrepancies nor do I see any holes.
| const removeDuplicates = (collection, cb) => { | ||
| // Write a function called removeDuplicates that removes all duplicate values from the given array. | ||
| // Pass the array to the callback function. Do not mutate the original array. | ||
| const fixedCollection = collection.slice(); |
Author
There was a problem hiding this comment.
When I was writing this, I think in my head I was trying to retain the original array, but offer up a second version, fixedCollection, with the duplicates removed. It may have been unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic