This repository was archived by the owner on Aug 31, 2019. It is now read-only.
Advanced JS #22
Closed
Advanced JS #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunJieMing
reviewed
Sep 1, 2017
| // Return `undefined` if no elements pass the truth test. | ||
|
|
||
| for (let i = 0; i < elements.length; i++) if (cb(elements[i]) === true) return elements[i]; | ||
| return 'undefined'; |
Contributor
There was a problem hiding this comment.
Actually return undefined and not the string 'undefined'
SunJieMing
reviewed
Sep 1, 2017
| if (Array.isArray(elements[i])) { | ||
| arr = arr.concat(flatten(elements[i])); | ||
| } else arr.push(elements[i]); | ||
| } return arr; |
Contributor
There was a problem hiding this comment.
Put the return on the next line
SunJieMing
reviewed
Sep 1, 2017
| } | ||
|
|
||
| comparePasswords(myPassword) { | ||
| if (this.password === myPassword) return true; |
Contributor
There was a problem hiding this comment.
Just do return this.password === myPassword; . It's automatically converted into a bool
SunJieMing
reviewed
Sep 1, 2017
| // use `this` to access the object's `password` property. | ||
| // do not modify this function's parameters | ||
| // note that we use the `function` keyword and not `=>` | ||
| if (passwordToCompare == this.password) { |
Contributor
There was a problem hiding this comment.
Same thing: return passwordToCompare === this.password;. Make sure to use === over ==
SunJieMing
reviewed
Sep 1, 2017
| // return `true` if they match, otherwise return `false` | ||
|
|
||
| checkPassword(string) { | ||
| if (string === this.password) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, haven't been able to finish this project just yet. Could you show us best practice solutions that we could compare / learn from?
Thanks in advance!