Add method to set secret after Webhook.__init__ #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a secret can only be set when the Webhook object is initialized. However, this limits your options for how you can load in the secret. For example, if a user's flask app parses a config file using the flask before_first_request decorator and they wanted to store the secret in that config file, then the only way to edit the value of the secret is by directly setting a private attribute of the object after initialization. This commit attemps to address this issue and support the use case where the config is after the Webhook object is initialized. It does this by adding a new public method, set_secret(), which can be used to set the set secret value for the webhook object just as if it was passed in as a kwarg to __init__(). Signed-off-by: Matthew Treinish <mtreinish@kortar.org>
Contributor
|
Thank you for taking the time to contribute this @mtreinish . I have chosen to merge the changes under #25 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a secret can only be set when the Webhook object is
initialized. However, this limits your options for how you can load in
the secret. For example, if a user's flask app parses a config file
using the flask before_first_request decorator and they wanted to store
the secret in that config file, then the only way to edit the value of
the secret is by directly setting a private attribute of the object
after initialization. This commit attemps to address this issue and
support the use case where the config is after the Webhook object is
initialized. It does this by adding a new public method, set_secret(),
which can be used to set the set secret value for the webhook object
just as if it was passed in as a kwarg to init().
Signed-off-by: Matthew Treinish mtreinish@kortar.org