Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

add support for GraphQL Docs Request for client request, add fix can'…#18

Open
yongboy wants to merge 1 commit intobjornbytes:masterbjornbytes/graphql-lua:masterfrom
yongboy:masteryongboy/graphql-lua:masterCopy head branch name to clipboard
Open

add support for GraphQL Docs Request for client request, add fix can'…#18
yongboy wants to merge 1 commit intobjornbytes:masterbjornbytes/graphql-lua:masterfrom
yongboy:masteryongboy/graphql-lua:masterCopy head branch name to clipboard

Conversation

@yongboy
Copy link

@yongboy yongboy commented Jun 30, 2017

Fix bugs:

  • Add GraphQL Introspection support for GraphQL Client (eg:chrome‘s GraphIQL Feen Plugin)init request avoiding show Docs failure
  • Fix does not get the InputObject's Parameter bug when need
  • Fix the directive does not work well with Variables's parameter bug

:))

…t get the InputObject's Parameter bug, and fix the directive does not work well bug.
resolve = function(kind)
if kind.__type == 'Object' then
return kind.interfaces
return kind.interface or {}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this still be .interfaces?

variableMap[_vn] = true
-- TODO Maybe danger
if not _cv[_vn] then
_cv[_vn] = true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leads to a regression where unused variables don't fail validation anymore, try validating query test($arg: String) {}.

@LennyPenny
Copy link

Any updates on this @yongboy?

@ruslantalpa
Copy link
Contributor

some of the changes are integrated here (PR will come later). https://github.com/ruslantalpa/graphql-lua/tree/deploy

the docs work for me

@andyvanee
Copy link

I'm not sure if this thread is dead, but I've got this working with GraphiQL with the following minimal patch: andyvanee@4785941

Also, I was a bit confused since the only available version on luarocks is the 0.0.2 tag, which is quite old and does not include many of the changes necessary to work with GraphiQL - particularly 119aafe . Perhaps it's time for an updated tag?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.