[PM-21713] Include CipherId and find Ciphers in Risk Insights report #14823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14823 +/- ##
==========================================
+ Coverage 36.81% 36.82% +0.01%
==========================================
Files 3199 3200 +1
Lines 92625 92727 +102
Branches 13906 13927 +21
==========================================
+ Hits 34101 34148 +47
- Misses 57118 57172 +54
- Partials 1406 1407 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ttalty
previously approved these changes
May 16, 2025
ttalty
previously approved these changes
Jun 2, 2025
ttalty
previously approved these changes
Jun 4, 2025
|
Banrion
approved these changes
Jun 4, 2025
ttalty
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21713
📔 Objective
The original code included the actual ciphers. This was incorrect. Each line item in the Risk Insights report is an aggregation and could consist of many ciphers.
This PR fixes the issue by storing the cipher ids along with the report.
The PR then finds the ciphers and uses it to render the Icons for each line item.
📸 Screenshots
No change to the UI - all UI elements must work as expected.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes