Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@leoj3n
Copy link
Contributor

@leoj3n leoj3n commented Apr 10, 2017

Related to bit-docs/bit-docs-generate-html#20

When you do npm install --save it uses syntax like file://, so might need to modify the code to support that case, but haven't tested if that's an issue or not.

leoj3n added a commit to bit-docs/bit-docs-generate-html that referenced this pull request Apr 10, 2017
Not needed now that bit-docs makes all file: paths absolute:

bit-docs/bit-docs#26
@leoj3n leoj3n requested a review from justinbmeyer April 10, 2017 09:28
@leoj3n leoj3n self-assigned this Apr 17, 2017
@leoj3n
Copy link
Contributor Author

leoj3n commented Apr 20, 2017

In defense of this PR, I can imagine someone having a legitimate reason to not want to publish to npm, nor create a separate github repo to contain a plugin. Perhaps it is someone using git-subtree and their website + plugins are a monorepo, or they just decided to have their plugins directly versioned in their website's master. In this case, they would benefit from being able to specify something along the lines of file:plugins/a-plugin.

Or, take for example the use case of git submodules.. Someone might want to have their plugins added as gitmodules under plugins/a-plugin, plugins/b-plugin, etc. They would have an expectation to be able to utilize these plugins again by specifying file:plugins/a-plugin and file:plugins/b-plugin like normal with npm.

As long as we are using npm under the hood, we shouldn't break people's expectations of how npm already works if it's possible not to. At least, I think we're being too opinionated if we do. I think we should save our opinions for good documentation, where we can cover the recommended way of testing plugins, with an explanation of the reasoning, without assuming people are using file: for that (evil) purpose, because as I've explained it might just be for an purely organizational preference.

@leoj3n
Copy link
Contributor Author

leoj3n commented Apr 20, 2017

Also, not accepting this PR doesn't stop people from using file: syntax, it just forces them to manually use absolute paths, while breaking lockstep with npm on the expectation of being able to use relative paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.