Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@leoj3n
Copy link
Contributor

@leoj3n leoj3n commented Mar 21, 2017

@justinbmeyer Would like your go-ahead before fixing these jshint errors:

  • Are you cool with these jshint settings?
  • Have I done a good job on the one file I fixed up in this PR (lib/generate/generate.js)?
    • Specifically, Is it okay to change siteConfig["static"] to siteConfig.static?

I know this isn't a high priority item, but think it's something that should be done sooner than later (before there's popularity and a bunch of PRs that will need to be restructured themselves).

This will be a sweeping change to many files, so ideally should be done all at once.

This is something I would like to do for all bit-docs repos; as an example, I've created a jshint branch for bit-docs-generate-html as well:

https://github.com/bit-docs/bit-docs-generate-html/tree/jshint

EDIT — I noticed bit-docs-process-mustache is one that already contain a .jshintrc:

https://github.com/bit-docs/bit-docs-process-mustache/blob/master/.jshintrc

@leoj3n leoj3n requested a review from justinbmeyer March 21, 2017 16:40
@leoj3n leoj3n self-assigned this Mar 21, 2017
@leoj3n
Copy link
Contributor Author

leoj3n commented Mar 21, 2017

Putting this on hold until we have some discussion in developer relations because @chasenlehara has asked me to do some research on the possibility of using eslint or prettier, instead of jshint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.