Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

More lenient mmCIF parsing#1083

Merged
josemduarte merged 3 commits intobiojava:masterbiojava/biojava:masterfrom
josemduarte:parseEsmCifFixjosemduarte/biojava:parseEsmCifFixCopy head branch name to clipboard
Mar 4, 2024
Merged

More lenient mmCIF parsing#1083
josemduarte merged 3 commits intobiojava:masterbiojava/biojava:masterfrom
josemduarte:parseEsmCifFixjosemduarte/biojava:parseEsmCifFixCopy head branch name to clipboard

Conversation

@josemduarte
Copy link
Contributor

ESMAtlas files miss some of the atom_site fields, which was breaking their parsing. This makes parsing more lenient, not requiring these fields if not present.

Copy link
Member

@sbittrich sbittrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@josemduarte josemduarte merged commit 8b0c430 into biojava:master Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.