Some more categories written out to CIF #1063
Merged
josemduarte merged 7 commits intobiojava:masterbiojava/biojava:masterfrom Jun 1, 2023
Merged
Some more categories written out to CIF #1063josemduarte merged 7 commits intobiojava:masterbiojava/biojava:masterfrom
josemduarte merged 7 commits intobiojava:masterbiojava/biojava:masterfrom
Conversation
sbittrich
reviewed
May 24, 2023
| entityDescriptions[i] = e.getDescription() == null? "?" : e.getDescription(); | ||
| } | ||
|
|
||
| String[] polyEntityIds = entityInfos.stream().filter(e -> e.getType() == EntityType.POLYMER).map(e -> Integer.toString(e.getMolId())).collect(Collectors.toList()).toArray(new String[]{}); |
Member
There was a problem hiding this comment.
Streams have a toArray method as well. .collect(Collectors.toList()).toArray(new String[]{}) can be simplified to .toArray(String[]::new), effectively skipping the creation of a List.
Contributor
Author
There was a problem hiding this comment.
Nice one, thanks. Added a commit.
And shame to IntelliJ for not suggesting this!
sbittrich
requested changes
May 24, 2023
Member
sbittrich
left a comment
There was a problem hiding this comment.
Thanks, code looks good and should solve our problem.
There are 2 stream expressions that can be simplified.
| } | ||
|
|
||
| String[] polyEntityIds = entityInfos.stream().filter(e -> e.getType() == EntityType.POLYMER).map(e -> Integer.toString(e.getMolId())).collect(Collectors.toList()).toArray(new String[]{}); | ||
| String[] polyEntitySeqs = entityInfos.stream().filter(e -> e.getType() == EntityType.POLYMER).map(e -> e.getChains().get(0).getSeqResSequence()).collect(Collectors.toList()).toArray(new String[]{}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
_entityand_entity_polyto CIF output, so that some more metadata is available for consumers.Also:
Chains when no entity info is present in input file