Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Harmonize Profile and LightweightProfile #1018

Copy link
Copy link
@sbliven

Description

@sbliven
Issue body actions

I think Profile was indended to be general enough to represent multiple sequence alignments. However SimpleProfile is the only current implementation and it only supports pairwise alignments. There is also LightweightProfile with similarly named methods that is implemented by MultipleSequenceAlignment and seems intended for ungapped sequences. Is that an accurate summary of the situation?

If so, I propose steps to

  • Make Profile<S,C> extend LightweightProfile<AlignedSequence<S,C>,C>
  • Improve documentation clarifying that SimpleProfile is pairwise
  • Deprecate one of Profile.StringFormat or LightweightProfile.StringFormat
  • Add constructors to ease conversion between SimpleProfile and MultipleSequenceAlignment instances
  • Document what toString(StringFormat) is expected to produce for each format. Ideally it should be the same for two or more sequences. If a format is only applicable to pairwise alignments this needs to be clearly documented.

The last point regarding formats is relevant to #983. I had difficulties recommending a solution because the pairwise and MSA outputs are different and undocumented.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.