Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c7261df

Browse filesBrowse files
authored
Merge pull request #1117 from biojava/jd/issue1116
Don't output label_seq_id for non-polymers in mmCIF writing
2 parents 21d61b1 + 274a36a commit c7261df
Copy full SHA for c7261df

File tree

Expand file treeCollapse file tree

2 files changed

+11
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+11
-1
lines changed
Open diff view settings
Collapse file

‎CHANGELOG.md‎

Copy file name to clipboardExpand all lines: CHANGELOG.md
+5Lines changed: 5 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
BioJava Changelog
22
-----------------
33

4+
BioJava 7.2.3 - future release
5+
==============================
6+
### Fixed
7+
* Don't use label_seq_id in mmCIF output for non-polymers #1116
8+
49
BioJava 7.2.2
510
==============================
611
### Fixed
Collapse file

‎biojava-structure/src/main/java/org/biojava/nbio/structure/io/cif/AbstractCifFileSupplier.java‎

Copy file name to clipboardExpand all lines: biojava-structure/src/main/java/org/biojava/nbio/structure/io/cif/AbstractCifFileSupplier.java
+6-1Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,12 @@ public void accept(WrappedAtom wrappedAtom) {
308308
}
309309
}
310310
labelEntityId.add(entityId);
311-
labelSeqId.add(seqId);
311+
// see https://github.com/biojava/biojava/issues/1116
312+
if (chain.getEntityInfo().getType() == EntityType.POLYMER) {
313+
labelSeqId.add(seqId);
314+
} else {
315+
labelSeqId.markNextNotPresent();
316+
}
312317
String insCode = "";
313318
if (group.getResidueNumber().getInsCode() != null) {
314319
insCode = Character.toString(group.getResidueNumber().getInsCode());

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.