Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 7 commits
- 3 files changed
- 2 contributors
Commits on Aug 8, 2024
Commits on Aug 9, 2024
-
-
For #492. BROKEN: Use Gradle error_prone plugin
See https://github.com/tbroyer/gradle-errorprone-plugin. Example error below. This error seems bizarre. Our code does not do this: perhaps generated code? ``` > Task :compileJava /home/binkley/src/java/modern-java-practices/src/main/java/demo/ErrorProneSpike.java:24: error: [CollectionIncompatibleType] Argument 'i - 1' should not be passed to this method; its type int is not compatible with its collection's type argument Short s.remove(i - 1); ^ (see https://errorprone.info/bugpattern/CollectionIncompatibleType) 1 error ```
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...error-prone-spike