Encoding checkpoint reshaping guide#349
Draft
tjruwase wants to merge 2 commits intomainbigscience-workshop/Megatron-DeepSpeed:mainfrom
universal_ckpt_infobigscience-workshop/Megatron-DeepSpeed:universal_ckpt_infoCopy head branch name to clipboard
Draft
Encoding checkpoint reshaping guide#349tjruwase wants to merge 2 commits intomainbigscience-workshop/Megatron-DeepSpeed:mainfrom universal_ckpt_infobigscience-workshop/Megatron-DeepSpeed:universal_ckpt_infoCopy head branch name to clipboard
tjruwase wants to merge 2 commits intomainbigscience-workshop/Megatron-DeepSpeed:mainfrom
universal_ckpt_infobigscience-workshop/Megatron-DeepSpeed:universal_ckpt_infoCopy head branch name to clipboard
Conversation
Collaborator
Author
|
@stas00, I don't intend for this to be merged. Rather, I am sharing this PR to get your feedback for the generalization effort. As discussed earlier, the core logic will eventually move to DS. |
stas00
approved these changes
Sep 20, 2022
Contributor
stas00
left a comment
There was a problem hiding this comment.
Looks pretty clean to me. Thank you for working on that, Tunji!
I know it's not as much fun when you're now working on it alone and without an immediately applicable context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a step towards generalizing the universal checkpointing approach that enables arbitrary reshapes of 3D parallel checkpoints. This PR eliminated the hardcoding of BLOOM model architecture in the current implementation as follow:
Requires the companion DS PR.