Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@dnjscksdn98
Copy link
Collaborator

@dnjscksdn98 dnjscksdn98 commented Oct 24, 2023

Description

  • This PR will resolve the inconsistency between transferrable and EVM balances
  • It also adds the missing insecure_zero_ed features for pallet_balances

Companion PR's

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Something else (simple changes that are not related to existing functionality or others)

Checklist

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have made new test codes regarding to my changes.
  • I have no personal secrets or credentials described on my changes.
  • I have run cargo-clippy and linted my code.
  • My changes generate no new warnings.
  • My changes passed the existing test codes.
  • My changes are able to compile.

@dnjscksdn98 dnjscksdn98 added the bug Working incorrectly label Oct 24, 2023
@dnjscksdn98 dnjscksdn98 self-assigned this Oct 24, 2023
@dnjscksdn98 dnjscksdn98 marked this pull request as draft October 24, 2023 14:25
@dnjscksdn98 dnjscksdn98 changed the title fix: add missing insecure_zero_ed features fix: use dedicated reducible balance for EVM Oct 25, 2023
@dnjscksdn98 dnjscksdn98 changed the title fix: use dedicated reducible balance for EVM fix: resolve balance inconsistency Oct 25, 2023
@dnjscksdn98 dnjscksdn98 marked this pull request as ready for review October 25, 2023 01:40
@dnjscksdn98 dnjscksdn98 merged commit 15c9636 into main Oct 25, 2023
@dnjscksdn98 dnjscksdn98 deleted the hotfix/use-insecure-zero-ed branch October 25, 2023 04:35
dnjscksdn98 added a commit that referenced this pull request Dec 1, 2023
* NODE-60, feature: enhance test codes (#24)

* NODE-60, feature: update test packages

* NODE-60, feature: update CLI tools

* NODE-60, feature: update local node test CLI's

* NODE-60, fix: update process exit code

* NODE-60, fix: resolve benchmark tests

* NODE-60, fix: use constant package versions

* NODE-60, feature: add tests for runtime upgrades

* NODE-60, chore: Remove redundant in test_runtime_upgrade.ts

* chore: Remove deployERC20.ts
* style: Indent

* NODE-60, fix: rollback to any type and increase sleep time

* NODE-60, fix: replace to greaterThanOrEqual

* NODE-60, fix: resolve package vulnerabilities

---------

Co-authored-by: alstjd0921 <kwonarseus@gmail.com>

* NODE-62, tests: add test codes for client upgrades (#25)

* NODE-64, chores: add systemd configuration examples (#26)

* NODE-64, chores: add systemd configuration examples

* NODE-64, chores: rename directory and add restart policy

* fix: resolve balance inconsistency (#27)

* fix: add missing insecure_zero_ed features

* chore: update deps

* chore: update deps

* chore: Rename rust-toolchain.toml from rust-toolchain

* chore: format Cargo.toml & clarify resolver="2"

* chore: Remove unused import

* chore: toolchain channel to stable

* chore: rollback toolchain

---------

Co-authored-by: alstjd0921 <kwonarseus@gmail.com>

* release: increase testnet runtime version

* fix: resolve CVE-2023-38497 (#28)

* release: increase dev runtime version

* chore: update deps (#29)

* update deps

* update deps

* release: increase mainnet runtime version

* update Cargo.lock

---------

Co-authored-by: alstjd0921 <kwonarseus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Working incorrectly

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.