Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Visibility issue of MainSecurityGuard#772

Open
Net-0 wants to merge 1 commit intobeanshell:masterbeanshell/beanshell:masterfrom
Net-0:securityguardNet-0/beanshell-securityguard:securityguardCopy head branch name to clipboard
Open

Visibility issue of MainSecurityGuard#772
Net-0 wants to merge 1 commit intobeanshell:masterbeanshell/beanshell:masterfrom
Net-0:securityguardNet-0/beanshell-securityguard:securityguardCopy head branch name to clipboard

Conversation

@Net-0
Copy link

@Net-0 Net-0 commented Aug 31, 2024

I just forgot to add a public in the class :|, sorry for that

@codecov
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (0ed20ed) to head (68d0e72).
Report is 31 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #772      +/-   ##
============================================
+ Coverage     74.26%   74.79%   +0.52%     
- Complexity     3114     3125      +11     
============================================
  Files           112      112              
  Lines          9572     9564       -8     
  Branches       1880     1880              
============================================
+ Hits           7109     7153      +44     
+ Misses         2115     2066      -49     
+ Partials        348      345       -3     
Flag Coverage Δ
unittests 74.79% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Net-0
Copy link
Author

Net-0 commented Sep 10, 2024

@Net-0
Copy link
Author

Net-0 commented Sep 11, 2024

Hello @nickl- , I created this PR to fix the visibility of MainSecurityGuard class, but reading the code, I guess that makes sense that the SecurityGuard classes be in a package called security at all, it makes the code less messy.

About the bsh.Types visibility, I added a public method in bsh.Reflect of getType to solve that.

I also make a doc and already put the link above, it seems good. When you aprove the PR, I could put the link in the main wiki page for the SecurityGuard wiki page.

It seems ok, I'm going to finish my PR with generated class improvements to I be finally able to end the lambda support, see ya :D

@Net-0 Net-0 force-pushed the securityguard branch 2 times, most recently from 4e12f16 to ef5a439 Compare October 20, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.