Visibility issue of MainSecurityGuard#772
Visibility issue of MainSecurityGuard#772Net-0 wants to merge 1 commit intobeanshell:masterbeanshell/beanshell:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
============================================
+ Coverage 74.26% 74.79% +0.52%
- Complexity 3114 3125 +11
============================================
Files 112 112
Lines 9572 9564 -8
Branches 1880 1880
============================================
+ Hits 7109 7153 +44
+ Misses 2115 2066 -49
+ Partials 348 345 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hello @nickl- , I created this PR to fix the visibility of MainSecurityGuard class, but reading the code, I guess that makes sense that the SecurityGuard classes be in a package called About the I also make a doc and already put the link above, it seems good. When you aprove the PR, I could put the link in the main wiki page for the SecurityGuard wiki page. It seems ok, I'm going to finish my PR with generated class improvements to I be finally able to end the lambda support, see ya :D |
4e12f16 to
ef5a439
Compare
I just forgot to add a
publicin the class :|, sorry for that