Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use same tol defaul values #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

jcao-bdai
Copy link
Collaborator

Update the default values for tol(lerance) across the board, with the following justifications:

  • Using the same default value should help set user expectations, particularly when combined with updated docstrings;
  • If these changes break any code, it might help push the user to review previous assumptions of numerical tolerances in the context of the actual use case.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8339b8f) 76.47% compared to head (211e47c) 76.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   76.47%   76.47%           
=======================================
  Files          24       24           
  Lines        5136     5136           
=======================================
  Hits         3928     3928           
  Misses       1208     1208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcao-bdai jcao-bdai marked this pull request as ready for review December 1, 2023 17:52
Copy link
Collaborator

@myeatman-bdai myeatman-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcao-bdai jcao-bdai merged commit a0bb12f into master Dec 1, 2023
@jcao-bdai jcao-bdai deleted the SW-561/use-same-tol-defaults branch December 1, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.