Appveyor automated CI #118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
caveat: this would not have spotted #116, as that was a problem with the precompiled gem. |
Collaborator
|
(Bumping for CI, sorry about the noise) |
Collaborator
|
Historically, our issue hasn't really been running the tests on Windows, but rather installing the pre-compiled versions of the gem (like you pointed out in your last comment). Using AppVeyor to run the tests is interesting, but not nearly as compelling and useful as using AppVeyor to install the gem — that's what was done in #171. Closing this in favor of that. Thanks for submitting your contribution, though! |
Author
|
Fine with me :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an appveyor.yml. Appveyor is similar to Travis, but runs on a windows host. This will make sure that build problems on windows surface early.
Example output can be seen here: https://ci.appveyor.com/project/ccoenen/bcrypt-ruby/build/5 (one build timeouted in bundler, everything else ran fine).