Initial implementation of RFC4998#343
Closed
veebee wants to merge 9 commits intobcgit:masterbcgit/bc-java:masterfrom
Closed
Initial implementation of RFC4998#343veebee wants to merge 9 commits intobcgit:masterbcgit/bc-java:masterfrom
veebee wants to merge 9 commits intobcgit:masterbcgit/bc-java:masterfrom
Conversation
|
Will this implementation be part of a future version of Bouncy Castle? Best, |
Collaborator
|
I've reviewed the ASN.1 classes and checked in versions of those (I think they're now correct, but without test data it's hard to tell). Please update the rest of the submission in light of the new ASN.1 classes. We also need some tests in general. |
Collaborator
|
Some of the asn1 classes now moved to asn1.tsp... DataGroup and some others added to org.bouncycastle.tsp |
Contributor
|
Closing this as an initial implementation is now in org.bouncycastle.tsp.ers The high-level ATS Chain and Sequence classes still need to be added, but it may require a slightly different approach to what is given in here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements RFC4998 - https://tools.ietf.org/html/rfc4998.
Note: the verification process does not check whether the Evidence Record embeds the revocation info related to the TSA certificate(s), as this was not specifically defined in the RFC (unless I'm mistaken).