Fixed crash on invalid hash table#61
Open
CycloneRing wants to merge 1 commit intobb107:masterbb107/MemoryModulePP:masterfrom
CycloneRing:hashtable-errorCycloneRing/MemoryModulePP:hashtable-errorCopy head branch name to clipboard
Open
Fixed crash on invalid hash table#61CycloneRing wants to merge 1 commit intobb107:masterbb107/MemoryModulePP:masterfrom CycloneRing:hashtable-errorCycloneRing/MemoryModulePP:hashtable-errorCopy head branch name to clipboard
CycloneRing wants to merge 1 commit intobb107:masterbb107/MemoryModulePP:masterfrom
CycloneRing:hashtable-errorCycloneRing/MemoryModulePP:hashtable-errorCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @bb107
while using mmpp I faced a crash in my application on initialization when another dll was loaded. I investigated the issue and found the root, I applied a fix that made the application work perfectly however i'm not sure what is exactly the issue however the hashtable is null. by returning in will work later. You may want to check this and make a better fix.
also there was a crash on exit from ntrtl.h which the code doesn't make sense to me
Flink = Entry->Flink; Blink = Entry->Blink; Blink->Flink = Flink; Flink->Blink = Blink;I fixed it by validation
And I believe it must be
Blink->Flink = Flink; Flink->Blink = Blink; Entry->Flink = NULL; Entry->Blink = NULL;