Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update bazel version in versions file #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update bazel version in versions file #839

wants to merge 1 commit into from

Conversation

hanneskaeufler
Copy link
Contributor

@hanneskaeufler hanneskaeufler commented Sep 25, 2022 •
edited
Loading

Bumps the bazel version to be up to date

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@hanneskaeufler
Copy link
Contributor Author

Can't really tell what the failing tests is, it passes for me locally

@groodt
Copy link
Collaborator

groodt commented Sep 26, 2022

The error in buildkite appears to be:

ERROR: <builtin>: fetching local_repository rule //external:rules_python.override: java.io.IOException: No WORKSPACE file found in /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/sandbox/linux-sandbox/114/execroot/rules_python/_tmp/b45ad76472382f795d1e61dde171a896/_bazel_buildkite-agent/38318e911819c1b3a890d526b9ce4994/external/rules_python.override
--
  | ERROR: No WORKSPACE file found in /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/sandbox/linux-sandbox/114/execroot/rules_python/_tmp/b45ad76472382f795d1e61dde171a896/_bazel_buildkite-agent/38318e911819c1b3a890d526b9ce4994/external/rules_python.override

I think I'll revert #837 so we can do them together once we figure out the issue.

@groodt
Copy link
Collaborator

groodt commented Sep 26, 2022

Correction, can you please try raise a "revert" PR @hanneskaeufler ? Then I can approve and merge without waiting for other maintainers.

@hanneskaeufler
Copy link
Contributor Author

@groodt sure, here you go: #842

@groodt
Copy link
Collaborator

groodt commented Sep 27, 2022

@hanneskaeufler You can either repurpose this PR to try and bump everything in a single PR. Or open a new clean PR.

@hanneskaeufler
Copy link
Contributor Author

hm, did the former, but something does indeed seem to be off here. I'm not yet knowledgable about bzlmod to really get a grip on this right now.

@hanneskaeufler hanneskaeufler deleted the patch-1 branch September 27, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thundergolfer thundergolfer Awaiting requested review from thundergolfer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanneskaeufler @groodt
Morty Proxy This is a proxified and sanitized view of the page, visit original site.