Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix for requirements_lock with PEP440 direct references #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2022
Merged

Fix for requirements_lock with PEP440 direct references #756

merged 2 commits into from
Jul 14, 2022

Conversation

groodt
Copy link
Collaborator

@groodt groodt commented Jul 14, 2022 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #742

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@groodt groodt marked this pull request as ready for review July 14, 2022 11:11
@groodt groodt requested review from brandjon and lberki as code owners July 14, 2022 11:11
@groodt groodt requested review from alexeagle, hrfuller and mattem and removed request for brandjon and lberki July 14, 2022 11:12
@groodt groodt merged commit 834149d into main Jul 14, 2022
@groodt groodt deleted the groodt-fix-direct-url-refs branch July 14, 2022 20:09
@groodt groodt mentioned this pull request Jul 14, 2022
Closed
alexgartner-bc pushed a commit to braincorp/rules_python that referenced this pull request Jul 29, 2022
@aptenodytes-forsteri @alexgartner-bc
Support "from" imports in the python gazelle plugin.
9dfb68f 
Fixes bazel-contrib#709.

Test case for pip imports using "from foo import bar".

Test cases for imports of the form "from foo import bar".

Remove unnecessary flag (replaced with continue's).

Make sure from imports work with std modules.

- Add test case with `from __future__ import print_function`.

Guard python_interpreter_target workspace name on None type check. (bazel-contrib#755)

Fix for requirements_lock with PEP440 direct references (bazel-contrib#756)

Fix indentation error.

- Make sure that `from foo import bar, baz` works.
- Add test case for this.
@renovate renovate bot mentioned this pull request Feb 14, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@hrfuller hrfuller Awaiting requested review from hrfuller

@mattem mattem Awaiting requested review from mattem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@groodt @alexeagle
Morty Proxy This is a proxified and sanitized view of the page, visit original site.