refactor: move all re-exports to private/reexports.bzl #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e52df0 to
9ddafd0
Compare
alexeagle
approved these changes
Jun 30, 2022
| @@ -21,26 +21,22 @@ migrated to Starlark, their implementations will be moved here. | ||
|
|
There was a problem hiding this comment.
the comment above feels like it should go to the new file, and the comment here should just be "public API" or sth
9ddafd0 to
ce92b39
Compare
mattem
added a commit
to mattem/rules_python
that referenced
this pull request
Jul 7, 2022
f0rmiga
pushed a commit
to mattem/rules_python
that referenced
this pull request
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all re-exported symbols in to
reexports.bzl.This is a needed prefactor step for #723 as we need to consume
py_libraryinternall in the macro, and doing so fromdefs.bzlwould introduce a cycle.