Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: cc_import for libpython #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2022
Merged

feat: cc_import for libpython #727

merged 3 commits into from
Jun 13, 2022

Conversation

f0rmiga
Copy link
Member

@f0rmiga f0rmiga commented Jun 10, 2022

Exposes a cc_import target for libpython. So far, we've only been exposing the headers but on hermetic environments without libpython being found in the system search paths, we need to expose those libraries too.

@f0rmiga f0rmiga requested review from brandjon and lberki as code owners June 10, 2022 21:24
@f0rmiga f0rmiga requested review from alexeagle and removed request for brandjon and lberki June 10, 2022 21:24
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
@f0rmiga f0rmiga force-pushed the f0rmiga/libpython branch from f157e85 to b02f839 Compare June 10, 2022 21:25
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
python/repositories.bzl Outdated Show resolved Hide resolved
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Copy link
Contributor

@hrfuller hrfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@f0rmiga f0rmiga merged commit c276cba into main Jun 13, 2022
@f0rmiga f0rmiga deleted the f0rmiga/libpython branch June 13, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.