Allow METADATA files in pip_repository generated targets #637
Conversation
|
|
||
| # Note: `METADATA` is important as it's consumed by https://docs.python.org/3/library/importlib.metadata.html | ||
| # `METADATA` is expected to be there to show dist-info files are included in the runfiles. | ||
| metadata_path = r.Rlocation("{}/METADATA".format(dist_info_dir)) |
There was a problem hiding this comment.
This is a restored regression test from #626 but has new meaning as it now uses METADATA files to ensure this isn't removed from the data attributes of generated targets.
| dist_info_ignores = [ | ||
| "**/*.dist-info/METADATA", | ||
| # RECORD is known to contain sha256 checksums of files which might include the checksums |
There was a problem hiding this comment.
Are there known examples this happens in? Some import lib functions fail still because they use data from RECORD, the files() method on a distribution for instance.
There was a problem hiding this comment.
I too have been wondering why we're doing so much non-standard unpacking and exclusion of files from wheel packages.
I'm trying to land a change that uses installer to bring some PEP standards into this rule set. See: #715
I think we need a better way to handle non-determinism. I think we need to either make it opt-in somehow, or direct people in how to use a "wheel only" setup (using --only-binary=:all:). If you do that, then the only non-determinism is generated .pyc files, which can be excluded/included via some parameters.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently
*.dist-info/METADATAfiles are excluded inpip_repositorygenerated targets. This is incorrect as it's consumed by https://docs.python.org/3/library/importlib.metadata.htmlIssue Number: N/A
What is the new behavior?
This change allows
METADATAfiles to be included inpip_repositorygenerated targets, enabling the use of https://docs.python.org/3/library/importlib.metadata.html.Does this PR introduce a breaking change?
Other information