Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Updated pip_repository data ignore patterns #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Updated pip_repository data ignore patterns #632

merged 1 commit into from
Mar 2, 2022

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Mar 2, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

This is a followup from #626 but allows a few files through

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@UebelAndre UebelAndre marked this pull request as ready for review March 2, 2022 05:30
@mattem
Copy link
Contributor

mattem commented Mar 2, 2022

nit: can you add a comment in the source or here as to the issues hit when excluding the full directory? Someone will go around this track again for sure.

@UebelAndre
Copy link
Contributor Author

nit: can you add a comment in the source or here as to the issues hit when excluding the full directory? Someone will go around this track again for sure.

@mattem How's this?

@mattem mattem merged commit 84a4506 into bazel-contrib:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.