restrict visibility on filegroup target only consumed in 1 place #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the extra review and sorry about the miss. I'll be sure to pay more attention to visibility going forward 馃榾 |
|
@UebelAndre thanks again for the PR, and don't worry about it. It's such a minor thing 馃檪 |
f0rmiga
approved these changes
Jan 25, 2022
Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewd #601 after it merged. Thanks for fixing this long outstanding annoyance 馃檪 @UebelAndre
If I understand this code correctly the filegroup is only consumed by
//python/pip_install/private:srcs_moduleand so you don't need public visibility on the target.