Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix broken pre-commit hook #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2021
Merged

Fix broken pre-commit hook #590

merged 1 commit into from
Dec 29, 2021

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Dec 29, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?
Fixed broken pre-commit hook

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #583

What is the new behavior?

In #583, the commit hooks were added but they were fighting each other. This change fixes it so they don't both always fail.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alexeagle alexeagle merged commit 356407d into bazel-contrib:main Dec 29, 2021
@UebelAndre UebelAndre deleted the cleanup branch December 29, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@andyscott andyscott Awaiting requested review from andyscott

@thundergolfer thundergolfer Awaiting requested review from thundergolfer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @alexeagle
Morty Proxy This is a proxified and sanitized view of the page, visit original site.