Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove forgotten fragments of pip_import rule. #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 31, 2021
Merged

Remove forgotten fragments of pip_import rule. #588

merged 3 commits into from
Dec 31, 2021

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Dec 29, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?
This is a follow up from #582

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Another implementation of whl_library can be found in pip_repository.bzl
https://github.com/bazelbuild/rules_python/blob/1152bd132806a64b174768e42bfb5b89553194f6/python/pip_install/pip_repository.bzl#L339-L346

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@UebelAndre
Copy link
Contributor Author

@alexeagle just FYI, this PR is also ready for review.

hrfuller
hrfuller approved these changes Dec 31, 2021
View reviewed changes
Copy link
Contributor

@hrfuller hrfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@hrfuller hrfuller merged commit da0efdb into bazel-contrib:main Dec 31, 2021
@UebelAndre UebelAndre deleted the legacy branch December 31, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrfuller hrfuller hrfuller approved these changes

@andyscott andyscott Awaiting requested review from andyscott

@brandjon brandjon Awaiting requested review from brandjon

@lberki lberki Awaiting requested review from lberki

@thundergolfer thundergolfer Awaiting requested review from thundergolfer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @hrfuller
Morty Proxy This is a proxified and sanitized view of the page, visit original site.