Remove return code type check. #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only floating-point objects have an is_integer method (cf. https://docs.python.org/3.10/library/stdtypes.html#typesnumeric), so this will actually raise an AttributeError whenever the main function returns an integer or None. sys.exit works just fine with any argument type, so there’s no need to check anything. The example at https://packaging.python.org/specifications/entry-points/#use-for-scripts also doesn’t contain a type check.
thundergolfer
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Happy with this change
https://github.com/python/cpython/blob/main/Python/sysmodule.c#L837 lays out the argument handling of sys.exit nicely. Non-integer is handled, and treated as exit(1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only floating-point objects have an is_integer
method (cf. https://docs.python.org/3.10/library/stdtypes.html#typesnumeric),
so this will actually raise an AttributeError whenever the main function
returns an integer or None. sys.exit works just fine with any argument type,
so there’s no need to check anything. The example at
https://packaging.python.org/specifications/entry-points/#use-for-scripts also
doesn’t contain a type check.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information