Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: rules_python 0.4.0 is not recent enough for pip_install example #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2021
Merged

fix: rules_python 0.4.0 is not recent enough for pip_install example #547

merged 2 commits into from
Oct 14, 2021

Conversation

thundergolfer
Copy link

Addresses #541

with fix I can get :main to run. Output is:

Target //:main up-to-date:
  bazel-bin/main
INFO: Elapsed time: 22.670s, Critical Path: 0.58s
INFO: 5 processes: 5 internal.
INFO: Build completed successfully, 5 total actions
INFO: Build completed successfully, 5 total actions
['DEFAULT_SESSION', 'NullHandler', 'Session', '__author__', ....
...

Does this PR introduce a breaking change?

  • Yes
  • No

@google-cla google-cla bot added the cla: yes label Oct 12, 2021
@thundergolfer thundergolfer requested review from alexeagle and hrfuller and removed request for andyscott October 12, 2021 12:25
@thundergolfer thundergolfer mentioned this pull request Oct 12, 2021
Closed
@alexeagle
Copy link
Contributor

What's the principled answer? We've always had this situation in rules_nodejs and our answer has been to cut releases often enough that the skew is rarely noticed, but sometimes get a similar issue filed.

Obviously we could just use local_repository(path="../..", name = "rules_python") so that the example always works in the repo, but then it's not a standalone example that ppl can copy into their code.
(In any case we'd still want the integration test runner to replace that with our distro package, so we get test coverage for the distro rather than working against the sources.)

@alexeagle alexeagle changed the title fix: rules_python 4.0.0 is not recent enough for pip_install example fix: rules_python 0.4.0 is not recent enough for pip_install example Oct 12, 2021
hrfuller
hrfuller approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@hrfuller hrfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my understanding that the examples were only expected to succeed as integration tests, but I'm fine bumping the version every so often.

@thundergolfer thundergolfer merged commit cd5416e into main Oct 14, 2021
@thundergolfer thundergolfer deleted the jonathon--fix-pip_install-example-oct2021 branch October 14, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrfuller hrfuller hrfuller approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thundergolfer @alexeagle @hrfuller
Morty Proxy This is a proxified and sanitized view of the page, visit original site.